rgoers commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r403820364
########## File path: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeLoggingTestUtil.java ########## @@ -16,35 +16,33 @@ */ package org.apache.logging.log4j.core; -import static org.junit.Assert.assertEquals; -import static org.junit.Assert.assertFalse; -import static org.junit.Assert.assertTrue; - -import java.io.File; -import java.net.URL; -import java.nio.charset.Charset; -import java.nio.file.Files; -import java.util.List; -import java.util.concurrent.atomic.AtomicBoolean; - +import com.google.monitoring.runtime.instrumentation.AllocationRecorder; +import com.google.monitoring.runtime.instrumentation.Sampler; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Marker; import org.apache.logging.log4j.MarkerManager; import org.apache.logging.log4j.ThreadContext; import org.apache.logging.log4j.core.util.Constants; import org.apache.logging.log4j.message.StringMapMessage; -import org.apache.logging.log4j.util.Strings; -import com.google.monitoring.runtime.instrumentation.AllocationRecorder; -import com.google.monitoring.runtime.instrumentation.Sampler; +import java.io.File; +import java.net.URL; +import java.nio.charset.Charset; +import java.nio.file.Files; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.regex.Pattern; Review comment: The order of imports no longer matches the style guide - http://logging.apache.org/log4j/2.x/javastyle.html. I should note though that we have lots of checkstyle errors in the existing code (they should be addressed). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
