[
https://issues.apache.org/jira/browse/LOG4J2-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16990379#comment-16990379
]
ASF subversion and git services commented on LOG4J2-2635:
---------------------------------------------------------
Commit 63a08d02bd8e9db8cffec2c12eab283f6ef3cf2f in logging-log4j2's branch
refs/heads/release-2.x from Ralph Goers
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=63a08d0 ]
LOG4J2-2635 - Wrong java version check in ThreadNameCachingStrategy
> Wrong java.version check in ThreadNameCachingStrategy
> -----------------------------------------------------
>
> Key: LOG4J2-2635
> URL: https://issues.apache.org/jira/browse/LOG4J2-2635
> Project: Log4j 2
> Issue Type: Bug
> Reporter: Filipp Gunbin
> Priority: Major
>
> I see this in ThreadNameCachingStrategy.java:
> {code:java}
> final String defaultStrategy =
> System.getProperty("java.version").compareTo("1.8.0_102") < 0
> ? "CACHED" // LOG4J2-2052 JDK 8u102 removed the String allocation in
> Thread.getName()
> : "UNCACHED";{code}
> This doesn't look right because java.version of, say, "1.8.0_77" compares
> greater than "1.8.0_102" lexicographically. This is why I have failed tests
> when trying to build log4j-core.
> Similar check is also present in AsyncLoggerThreadNameStrategyTest.java.
> This was initially added in https://issues.apache.org/jira/browse/LOG4J2-2052
> [posted this on dev mailing list first, but got no response, so creating
> issue here]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
