[
https://issues.apache.org/jira/browse/LOG4J2-2634?focusedWorklogId=263865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-263865
]
ASF GitHub Bot logged work on LOG4J2-2634:
------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/19 15:48
Start Date: 20/Jun/19 15:48
Worklog Time Spent: 10m
Work Description: carterkozak commented on pull request #282:
LOG4J2-2634: Break up large AsyncLogger methods for inlining
URL: https://github.com/apache/logging-log4j2/pull/282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 263865)
Time Spent: 10m
Remaining Estimate: 0h
> AsyncLogger method bytecode should be reduced to 35 bytes for fast inlining
> ---------------------------------------------------------------------------
>
> Key: LOG4J2-2634
> URL: https://issues.apache.org/jira/browse/LOG4J2-2634
> Project: Log4j 2
> Issue Type: Improvement
> Affects Versions: 2.11.2
> Reporter: Carter Kozak
> Assignee: Carter Kozak
> Priority: Minor
> Fix For: 2.12.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Large methods:
> AsyncLogger.logMessage conditional behavior produces a large method, this can
> be broken into an abstraction which two implementations.
>
> AsyncLogger.actualAsyncLog can be inlined in cases where Properties are not
> set
> RingBufferLogEventHandler.onEvent callback notification makes sense in a
> separate method so that both are below 35b
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
