[ 
https://issues.apache.org/jira/browse/LOG4J2-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868646#comment-16868646
 ] 

ASF subversion and git services commented on LOG4J2-2634:
---------------------------------------------------------

Commit ef7121e908b58752368dcc434ad0612c2473d5a3 in logging-log4j2's branch 
refs/heads/master from Carter Kozak
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=ef7121e ]

Merge pull request #282 from carterkozak/ckozak/async_logger_35byte_methods

LOG4J2-2634: Break up large AsyncLogger methods for inlining

> AsyncLogger method bytecode should be reduced to 35 bytes for fast inlining
> ---------------------------------------------------------------------------
>
>                 Key: LOG4J2-2634
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2634
>             Project: Log4j 2
>          Issue Type: Improvement
>    Affects Versions: 2.11.2
>            Reporter: Carter Kozak
>            Assignee: Carter Kozak
>            Priority: Minor
>             Fix For: 2.12.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Large methods:
> AsyncLogger.logMessage conditional behavior produces a large method, this can 
> be broken into an abstraction which two implementations.
>  
> AsyncLogger.actualAsyncLog can be inlined in cases where Properties are not 
> set
> RingBufferLogEventHandler.onEvent callback notification makes sense in a 
> separate method so that both are below 35b



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to