micafer commented on PR #2066:
URL: https://github.com/apache/libcloud/pull/2066#issuecomment-6910435506

   One of the tests are failing:
   Please could you update the example: 
https://github.com/apache/libcloud/blob/trunk/example_dns.py
   It uses the deleted Zerigo DNS driver to make the test, could you update it 
to use any other?
   
   > World Wide DNS — update_record() fails when extra=None.
   
   I prefer that, at least in the drivers modified in this PR that this error 
is solved.
   Then we can open another PR to fix the rest.
   It requires a minor change:
   
   ```py
   def update_record(self, record, name, type, data, extra=None):
       record_id = record.id
       if extra and "entry" in extra and str(extra["entry"]) != record_id:
           raise WorldWideDNSError(...)
   ```
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to