PsiACE commented on code in PR #2147:
URL: https://github.com/apache/libcloud/pull/2147#discussion_r3610988246


##########
libcloud/compute/drivers/upcloud.py:
##########
@@ -95,16 +123,35 @@ class UpcloudDriver(NodeDriver):
         "error": NodeState.ERROR,
     }
 
-    def __init__(self, username, password, **kwargs):
-        super().__init__(key=username, secret=password, **kwargs)
+    STORAGE_VOLUME_STATE_MAP = {
+        "online": StorageVolumeState.AVAILABLE,
+        "maintenance": StorageVolumeState.UPDATING,
+        "cloning": StorageVolumeState.CREATING,

Review Comment:
   > cloning: The storage resource is currently the clone source for another 
storage.
   
   emmmmm, `creating` may not a good state. any idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to