GitHub user techhat opened a pull request:
https://github.com/apache/libcloud/pull/1030
Fix impossible location condition
## Changes Title (replace this with a logical title for your changes)
Fix impossible location condition
### Description
When requesting a list of publishers from other parts of the code (such as
when listing images), a condition can be encountered where the `location` has
been passed in (and therefore is not `None`), but `self.default_location` is
also set. The `location` that is passed in should be used, but the condition
doesn't allow it to be.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [ ] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [ ] Documentation
- [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/techhat/libcloud publisherfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1030.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1030
----
commit 4c2e56093586104f9e3e72f43ddfba3fa4765f96
Author: Joseph Hall <perlho...@gmail.com>
Date: 2017-04-10T22:37:17Z
Fix impossible location condition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
