GitHub user samuelchong opened a pull request:
https://github.com/apache/libcloud/pull/893
New Feature - Edit Dimension Data Firewall Rule
## Changes Title (replace this with a logical title for your changes)
### Description
Implemented a new feature to DD libcloud to Edit Firewall Rule. This
feature didn't exists before but it is now made available. Firewall rule will
also accept portlist and ipaddresslist. Code snippet provided in the comment
section of each method.
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [Y] [Code
linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide)
(required, can be done after the PR checks)
- [Y] Documentation
- [Y] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ]
[ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes)
(required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samuelchong/libcloud editfw
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/893.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #893
----
commit ff06265c4132b15b8818f795980a5ba04b8aeb22
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-05T02:05:46Z
Added property plan in DimensionDataNetworkDomain return
commit 7440bf51c023936c7d1895e8f37ce707b26832d7
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-05T06:07:15Z
Merge remote-tracking branch 'apache/trunk' into trunk
commit 2672b78f9a9ee5f88656ba5dce9366493b73f65f
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T00:04:39Z
Merge branch 'trunk' of https://github.com/samuelchong/libcloud into trunk
commit 5327c11048392f06eef901547a94bd899a26169d
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T00:26:56Z
Added post_list_id property to DimensionDataFirewallAddress class
commit e6d582e55c4f5bbc906456b7003ded471a6434c6
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T00:30:46Z
Added Data contract classes for IpAddressList, PortList, NIC
commit 2eb1b4a32e1048d063da0ebea4cac01f2da60270
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T00:43:28Z
Added Edit firewall rule feature and CRUD operation for IpAddressList,
PortList in DD driver
commit 009f2266d4d4d1dff1bd6d83463b37757796f787
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T00:46:16Z
Removed unused import
commit 04c70e2285f3e2d64f72b16874f0882374133701
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T04:14:00Z
Unit test for firewall edit, portlist CRUD and IPAddressList CRUD
commit 026c973e6f5114825c04c69128401f94e89434c5
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-06T05:54:54Z
rename property name to child_portlist_list
commit 9e3c7da2403b30da67441e5a63ca79fff6236e3d
Author: Samuel Chong <samuelcho...@gmail.com>
Date: 2016-10-07T06:05:40Z
Add sample code for Edit FW, CRUD for ipaddresslist and portlist
Add sample codes and rename port_list_list to portlist_list to avoid
confusion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
