Repository: libcloud
Updated Branches:
  refs/heads/trunk 67a993fd9 -> 2e036dae4


Fixed bug in public IP addition command

Closes #661


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/2e036dae
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/2e036dae
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/2e036dae

Branch: refs/heads/trunk
Commit: 2e036dae4a41b59009eb2205df4d3f1ec03beee2
Parents: 67a993f
Author: anthony-shaw <anthony.p.s...@gmail.com>
Authored: Mon Dec 21 09:05:16 2015 +1100
Committer: anthony-shaw <anthony.p.s...@gmail.com>
Committed: Mon Dec 21 09:43:46 2015 +1100

----------------------------------------------------------------------
 libcloud/compute/drivers/dimensiondata.py               |  2 +-
 ..._4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/2e036dae/libcloud/compute/drivers/dimensiondata.py
----------------------------------------------------------------------
diff --git a/libcloud/compute/drivers/dimensiondata.py 
b/libcloud/compute/drivers/dimensiondata.py
index e195045..9f22e31 100644
--- a/libcloud/compute/drivers/dimensiondata.py
+++ b/libcloud/compute/drivers/dimensiondata.py
@@ -873,7 +873,7 @@ class DimensionDataNodeDriver(NodeDriver):
         block_id = None
 
         for info in findall(response, 'info', TYPES_URN):
-            if info.get('name') == 'publicIpBlockId':
+            if info.get('name') == 'ipBlockId':
                 block_id = info.get('value')
         return self.ex_get_public_ip_block(block_id)
 

http://git-wip-us.apache.org/repos/asf/libcloud/blob/2e036dae/libcloud/test/compute/fixtures/dimensiondata/caas_2_1_8a8f6abc_2745_4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml
----------------------------------------------------------------------
diff --git 
a/libcloud/test/compute/fixtures/dimensiondata/caas_2_1_8a8f6abc_2745_4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml
 
b/libcloud/test/compute/fixtures/dimensiondata/caas_2_1_8a8f6abc_2745_4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml
index 1fcb8d3..5555132 100644
--- 
a/libcloud/test/compute/fixtures/dimensiondata/caas_2_1_8a8f6abc_2745_4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml
+++ 
b/libcloud/test/compute/fixtures/dimensiondata/caas_2_1_8a8f6abc_2745_4d8a_9cbc_8dabe5a7d0e4_network_addPublicIpBlock.xml
@@ -1,7 +1,7 @@
-<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<response 
requestId="na/2014-04-14T13:37:20/62f06368-c3fb-11e3-b29c-001517c4643e" 
xmlns="urn:didata.com:api:cloud:types">
-<operation>ADD_PUBLIC_IP_BLOCK</operation>
-<responseCode>OK</responseCode>
-<message>Public IPv4 Address Block has been added successfully to Network 
Domain.</message>
-<info name="publicIpBlockId" value="4487241a-f0ca-11e3-9315-d4bed9b167ba"/>
+<?xml version="1.0" encoding="UTF-8"?>
+<response xmlns="urn:didata.com:api:cloud:types" 
requestId="na/2015-12-20T16:59:48.842-05:00/28d362bb-249c-42b6-9236-ddd8729f332c">
+    <operation>ADD_PUBLIC_IP_BLOCK</operation>
+    <responseCode>OK</responseCode>
+    <message>Public IPv4 Address Block has been added successfully to Network 
Domain d3320077-c2ce-4523-8c65-d417e766077b.</message>
+    <info name="ipBlockId" value="4487241a-f0ca-11e3-9315-d4bed9b167ba"/>
 </response>
\ No newline at end of file

Reply via email to