pan3793 commented on code in PR #7385:
URL: https://github.com/apache/kyuubi/pull/7385#discussion_r3063248232
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -113,6 +116,17 @@ private[kyuubi] class EngineRef(
@VisibleForTesting
private[kyuubi] val subdomain: String =
conf.get(ENGINE_SHARE_LEVEL_SUBDOMAIN) match {
+ // DATA_AGENT engines must be isolated by datasource (JDBC URL). This
takes precedence over
Review Comment:
let's update it as your proposed comment for now, and then I will merge this
PR to unblock your subsequent PRs, we can revise this later if we find any
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
