wangzhigang1999 commented on code in PR #7385:
URL: https://github.com/apache/kyuubi/pull/7385#discussion_r3043770120
##########
build/dist:
##########
@@ -363,6 +364,18 @@ for jar in $(ls "$DISTDIR/jars/"); do
fi
done
+# Copy data-agent engines
+cp
"$KYUUBI_HOME/externals/kyuubi-data-agent-engine/target/kyuubi-data-agent-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/data-agent/"
+cp -r
"$KYUUBI_HOME"/externals/kyuubi-data-agent-engine/target/scala-$SCALA_VERSION/jars/*.jar
"$DISTDIR/externals/engines/data-agent/"
+
+# Share the jars w/ server to reduce binary size
+# shellcheck disable=SC2045
+for jar in $(ls "$DISTDIR/jars/"); do
+ if [[ -f "$DISTDIR/externals/engines/data-agent/$jar" ]]; then
+ (cd $DISTDIR/externals/engines/data-agent; ln -snf "../../../jars/$jar"
"$DISTDIR/externals/engines/data-agent/$jar")
Review Comment:
the unquoted $DISTDIR in cd is a fair point, but this follows the existing
pattern used by all other engines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
