pan3793 commented on code in PR #7329:
URL: https://github.com/apache/kyuubi/pull/7329#discussion_r2902229691
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTable.scala:
##########
@@ -112,4 +116,92 @@ case class HiveTable(
override def capabilities(): util.Set[TableCapability] = {
util.EnumSet.of(BATCH_READ, BATCH_WRITE, OVERWRITE_BY_FILTER,
OVERWRITE_DYNAMIC)
}
+
+ override def createPartition(ident: InternalRow, properties:
util.Map[String, String]): Unit = {
+ val spec = toPartitionSpec(ident)
+ val location =
Option(properties.get(HiveTableProperties.LOCATION)).map(new URI(_))
+ val newPart = CatalogTablePartition(
+ spec,
+ catalogTable.storage.copy(locationUri = location),
+ properties.asScala.toMap)
+ hiveTableCatalog.externalCatalog.createPartitions(
+ catalogTable.database,
+ catalogTable.identifier.table,
+ Seq(newPart),
+ ignoreIfExists = false)
+ }
+
+ override def dropPartition(ident: InternalRow): Boolean = {
+ try {
+ hiveTableCatalog.externalCatalog.dropPartitions(
+ catalogTable.database,
+ catalogTable.identifier.table,
+ Seq(toPartitionSpec(ident)),
+ ignoreIfNotExists = false,
+ purge = false,
+ retainData = false)
+ true
+ } catch {
+ case _: NoSuchPartitionException => false
+ }
+ }
+
+ override def replacePartitionMetadata(
+ ident: InternalRow,
+ properties: util.Map[String, String]): Unit = {
+ throw new UnsupportedOperationException("Replace partition is not
supported")
Review Comment:
```suggestion
throw new UnsupportedOperationException("Replace partition metadata is
not supported")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
