nacx commented on a change in pull request #125:
URL: https://github.com/apache/jclouds/pull/125#discussion_r780968370
##########
File path: apis/s3/src/main/java/org/jclouds/s3/config/S3HttpApiModule.java
##########
@@ -184,7 +184,7 @@ protected void bindErrorHandlers() {
}
protected void bindRequestSigner() {
-
bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV2.class).in(Scopes.SINGLETON);
+
bind(RequestAuthorizeSignature.class).to(RequestAuthorizeSignatureV4.class).in(Scopes.SINGLETON);
Review comment:
The approach looks good @gaul. Probably the code moving needs to change
to something [like
this](https://github.com/apache/jclouds/blob/master/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/auth/config/AuthenticationModule.java#L61-L77).
The selected lines are the ones that configure, in OpenStack, the version of
the Keystone API to inject based on a property. A similar pattern could be used
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
