nacx commented on this pull request.


> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String 
> resourceGroup, String group
                logger.debug(">> deleting orphaned security group %s from 
%s...", name, resourceGroup);
                try {
                   deleted = resourceDeleted.apply(sgapi.delete(name));
+                  
resourceRemoved.apply(IdReference.create(securityGroup.id()));

Then, please add a comment in places where we are using this, to make explicit 
this is done to deal with eventual consistency issues. Otherwise, we might be 
tempted to accidentally change this in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1240#discussion_r235879058

Reply via email to