lowka commented on code in PR #7703:
URL: https://github.com/apache/ignite-3/pull/7703#discussion_r2939781173
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/ModifyNodeVisitor.java:
##########
@@ -332,4 +378,113 @@ public RexNode visitInputRef(RexInputRef inputRef) {
return null;
}
+
+ private @Nullable List<List<RexNode>> extractValuesFromScan(
+ IgniteRel rel,
+ long sourceId,
+ IgniteTable table,
+ @Nullable ImmutableIntList requiredColumns,
+ @Nullable List<RexNode> projects
+ ) {
+
+ PartitionPruningColumns metadata = extractor.result.get(sourceId);
+ // Do not propagate metadata if tables are different for now.
+ IgniteTable tableUnderModification = modifiedTable.getFirst();
+ if (metadata == null || tableUnderModification.id() != table.id()) {
+ return null;
+ }
+
+ // Only handle column order-preserving projections for now.
+ boolean preserveOrder = requiredColumns != null &&
projectionPreservesColumnOrder(requiredColumns);
Review Comment:
Fixed.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/ModifyNodeVisitor.java:
##########
@@ -73,7 +85,19 @@
class ModifyNodeVisitor implements IgniteRelVisitor<List<List<RexNode>>> {
private static final IgniteLogger LOG =
Loggers.forClass(ModifyNodeVisitor.class);
- private ModifyNodeVisitor() {
+ /**
+ * A placeholder used to designate that there is no value for a column. If
PP metadata collection algorithm encounters this placeholder
+ * in a colocation column for a source, then there can be no PP metadata
for this source. Since this is a marker to terminate
+ * algorithm, the type chosen for this expression does not matter.
+ */
+ static final RexNode VALUE_NOT_ASSIGNED = new RexInputRef(0,
Commons.typeFactory().createSqlType(SqlTypeName.NULL));
+
+ private final PartitionPruningMetadataExtractor extractor;
+
+ private Pair<IgniteTable, Operation> modifiedTable;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
