Vladsz83 commented on code in PR #12878:
URL: https://github.com/apache/ignite/pull/12878#discussion_r2923045068
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessageFactory.java:
##########
@@ -345,17 +346,35 @@
import
org.apache.ignite.spi.communication.tcp.messages.NodeIdMessageSerializer;
import
org.apache.ignite.spi.communication.tcp.messages.RecoveryLastReceivedMessage;
import
org.apache.ignite.spi.communication.tcp.messages.RecoveryLastReceivedMessageSerializer;
+import org.jetbrains.annotations.Nullable;
/**
* Message factory implementation.
*/
public class GridIoMessageFactory implements MessageFactoryProvider {
+ /** Custom data marshaller. */
+ private final @Nullable Marshaller cstDataMarshall;
+
+ /** Class loader for the custom data marshalling. */
+ private final @Nullable ClassLoader cstDataMarshallClsLdr;
+
+ /**
+ * @param cstDataMarshall Custom data marshaller.
+ * @param cstDataMarshallClsLdr Class loader for the custom data
marshalling.
+ */
+ public GridIoMessageFactory(@Nullable Marshaller cstDataMarshall,
@Nullable ClassLoader cstDataMarshallClsLdr) {
+ assert cstDataMarshall == null && cstDataMarshallClsLdr == null ||
cstDataMarshall != null && cstDataMarshallClsLdr != null;
Review Comment:
Actually, I'm no sure that nulls are allowed here. Generated message
serializers can't work with nullable marshaller and nullable class loader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
