ivanzlenko commented on code in PR #7753:
URL: https://github.com/apache/ignite-3/pull/7753#discussion_r2918901335
##########
migration-tools/modules/migration-tools-commons/src/main/java/org/apache/ignite/migrationtools/config/Ignite3ConfigurationUtils.java:
##########
@@ -65,7 +68,7 @@ public static CombinedConfigRegistry
loadCombinedRegistry(Path nodeCfgPath, Path
* @param includeDefaults Include defaults.
*/
public static ConfigurationRegistry loadNodeConfiguration(Path cfgPath,
boolean includeDefaults) {
- return loadConfigurations(cfgPath,
ConfigurationModules.create(null).local(), includeDefaults);
+ return loadConfigurations(cfgPath,
CompoundModule.local(ConfigurationModule.loadAll(null)), includeDefaults);
Review Comment:
This static methods not even used... The issue was pre-existent and I do not
wanna mess around with migration-utils code base at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
