dant3 commented on code in PR #7422: URL: https://github.com/apache/ignite-3/pull/7422#discussion_r2834620147
########## modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RunConsistentlyMetrics.java: ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.storage.pagememory.mv; + +import org.apache.ignite.internal.metrics.AtomicIntMetric; +import org.apache.ignite.internal.metrics.DistributionMetric; +import org.apache.ignite.internal.pagememory.metrics.CollectionMetricSource; + +/** + * Metrics for runConsistently operation. + * + * <p>Tracks runConsistently closure execution performance including duration + * and active call count. + */ +public class RunConsistentlyMetrics { + /** + * Histogram buckets for runConsistently duration in nanoseconds. + * + * <p>Covers operations from fast single-row writes to slow bulk operations with checkpoint contention: + * <ul> + * <li>10µs: Fast single-row operations without lock contention</li> + * <li>100µs: Multi-row operations, small index operations</li> + * <li>1ms: Medium-sized operations</li> + * <li>10ms: Larger operations, small vacuum operations</li> + * <li>100ms: Large operations, significant vacuum work</li> + * <li>1s: Very slow operations, likely checkpoint write lock contention</li> + * <li>10s: Pathological cases requiring investigation</li> Review Comment: Those numbers are guestimates. Sure, I can remove this if you think it doesnt bring value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
