shishkovilja commented on code in PR #12759:
URL: https://github.com/apache/ignite/pull/12759#discussion_r2832697680
##########
modules/codegen/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -317,14 +316,14 @@ private void readField(VariableElement field, int opt)
throws Exception {
private void returnFalseIfWriteFailed(VariableElement field) throws
Exception {
String methodName = field.getAnnotation(Order.class).method();
- String getExpr = (F.isEmpty(methodName) ?
field.getSimpleName().toString() : methodName) + "()";
+ String getExpr = (F.isEmpty(methodName) ?
field.getSimpleName().toString() : methodName + "()");
Review Comment:
```suggestion
String getExpr = F.isEmpty(methodName) ?
field.getSimpleName().toString() : methodName + "()";
```
##########
modules/codegen/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -462,37 +460,64 @@ private String typeNameToFieldName(String typeName) {
}
/**
- * Generate code of writing single field:
+ * Generate code of writing header:
Review Comment:
```suggestion
* Generate code of writing header.
```
##########
modules/codegen/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -708,57 +729,60 @@ private PrimitiveType unboxedType(TypeMirror type) {
/**
* Generate code of reading single field:
Review Comment:
```suggestion
* Generate code of reading single field.
```
##########
modules/core/src/test/resources/codegen/TestMessage.java:
##########
@@ -30,170 +30,49 @@
public class TestMessage implements Message {
@Order(0)
- private int id;
+ int id;
@Order(1)
- private byte[] byteArr;
+ byte[] byteArr;
@Order(2)
- private String str;
+ String str;
@Order(3)
- private String[] strArr;
+ String[] strArr;
@Order(4)
- private int[][] intMatrix;
+ int[][] intMatrix;
@Order(5)
- private GridCacheVersion ver;
+ GridCacheVersion ver;
@Order(6)
- private GridCacheVersion[] verArr;
+ GridCacheVersion[] verArr;
@Order(7)
- private UUID uuid;
+ UUID uuid;
@Order(8)
- private IgniteUuid ignUuid;
+ IgniteUuid ignUuid;
@Order(9)
- private AffinityTopologyVersion topVer;
+ AffinityTopologyVersion topVer;
@Order(10)
- private BitSet bitSet;
+ BitSet bitSet;
- @Order(value = 11, method = "overridenFieldMethod")
Review Comment:
Should we keep such method for test purposes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
