Lalant commented on code in PR #7482:
URL: https://github.com/apache/ignite-3/pull/7482#discussion_r2832557754
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##########
@@ -526,7 +526,7 @@ public static TableNotFoundException
tableIdNotFoundException(Integer tableId) {
// Remote transaction will be synchronously rolled
back if the timeout has exceeded.
if (remote.isRolledBackWithTimeoutExceeded()) {
throw new
TransactionException(TX_ALREADY_FINISHED_WITH_TIMEOUT_ERR,
- "Transaction is already finished [tx="
+ remote + "].");
+ "Transaction is already finished or
finishing [tx=" + remote + "].");
Review Comment:
Yes, you are right. We used to have 1 exception message for 2 different
error codes. I extended this message and it looks confusing. Actually we need 2
messages:
1. Transaction is already finished or finishing
2. Transaction is already finished due to timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
