Pochatkin commented on code in PR #7122: URL: https://github.com/apache/ignite-3/pull/7122#discussion_r2832464452
########## examples/java/src/main/java/org/apache/ignite/example/code/deployment/AbstractDeploymentUnitExample.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.example.code.deployment; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; +import org.apache.ignite.example.util.DeployComputeUnit; + +public class AbstractDeploymentUnitExample { Review Comment: The class still exists as a separate utility even though no example extends it anymore (good — the inheritance anti-pattern is gone). However, as I mentioned in my previous review, this class should be deleted entirely. All its logic — argument parsing, JAR path resolution, and the `processDeploymentUnit()` method — fits naturally into `DeployComputeUnit`, which is already the utility class for deployment operations. Having two utility classes for the same concern (`AbstractDeploymentUnitExample` + `DeployComputeUnit`) is unnecessary indirection. Please consolidate `processDeploymentUnit()` and the JAR path fields into `DeployComputeUnit`, then delete this class and update all callers to use `DeployComputeUnit` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
