xtern commented on code in PR #7623:
URL: https://github.com/apache/ignite-3/pull/7623#discussion_r2826789304
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItFloatingPointTest.java:
##########
@@ -441,17 +442,34 @@ void testIsDistinctFrom() {
}
@Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-27779";)
void testAggregations() {
- for (Ignite node : List.of(node(0), node(1))) {
- assertQuery(node, "SELECT MIN(f), MIN(d) FROM
test").returns(Float.NEGATIVE_INFINITY, Double.NEGATIVE_INFINITY).check();
- assertQuery(node, "SELECT MAX(f), MAX(d) FROM
test").returns(Float.NaN, Double.NaN).check();
- assertQuery(node, "SELECT AVG(f), AVG(d) FROM
test").returns(Double.NaN, Double.NaN).check();
-
- assertQuery(node, "SELECT MIN(fn), MIN(dn) FROM
test").returns(Float.NEGATIVE_INFINITY, Double.NEGATIVE_INFINITY).check();
- assertQuery(node, "SELECT MAX(fn), MAX(dn) FROM
test").returns(Float.NaN, Double.NaN).check();
- assertQuery(node, "SELECT AVG(fn), AVG(dn) FROM
test").returns(Double.NaN, Double.NaN).check();
- }
+ // Using an explicit RO transaction to read actual state of data on
both nodes.
+ // Otherwise, the implicit transaction on node 1 might step back a bit
in past and read the previous state.
+ node(0).transactions().runInTransaction(tx -> {
Review Comment:
Thanks, test fix reworked, please take a look.
To prevent tx run in past I forcibly update observable time on node1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
