Copilot commented on code in PR #7626:
URL: https://github.com/apache/ignite-3/pull/7626#discussion_r2825954568
##########
modules/client-common/src/main/java/org/apache/ignite/internal/compute/SharedComputeUtils.java:
##########
@@ -178,9 +233,9 @@ public static <T> ComputeJobDataHolder marshalArgOrResult(
if (type != MARSHALLED_CUSTOM && marshaller != null) {
throw new ComputeException(
MARSHALLING_TYPE_MISMATCH_ERR,
- "Marshaller is defined on the server, but the argument was
not marshalled on the client. "
+ unexpectedMarshallerErrorMessage + " "
+ "If you want to use default marshalling
strategy, "
- + "then you should not define your marshaller in
the job. "
+ + "then you should not define your marshaller only
in one place. "
Review Comment:
The error message has a grammatical issue: "then you should not define your
marshaller only in one place" is awkward and unclear. This should be rephrased
to something clearer like "then you should not define the marshaller" or "then
marshallers should not be defined on either side". The current phrasing with
"only in one place" is confusing because it seems to suggest defining it in one
place is wrong, but the context is that it's defined in both places incorrectly.
```suggestion
+ "then you should not define a custom
marshaller. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
