xtern commented on code in PR #7621:
URL: https://github.com/apache/ignite-3/pull/7621#discussion_r2822324662
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/SqlOutdatedPlanTest.java:
##########
@@ -188,41 +186,38 @@ private static CatalogCommand makeAddColumnCommand(String
columnName) {
private static class PrepareServiceSpy {
private final AtomicInteger callsCounter = new AtomicInteger();
- private final AtomicReference<ReentrantLock> prepareBlockHolder = new
AtomicReference<>();
+ private final AtomicReference<Semaphore> prepareBlockHolder = new
AtomicReference<>();
PrepareServiceSpy(TestNode gatewayNode) {
((PrepareServiceWithPrepareCallback) gatewayNode.prepareService())
.setPrepareCallback(() -> {
callsCounter.incrementAndGet();
- Lock lock = prepareBlockHolder.get();
+ Semaphore semaphore = prepareBlockHolder.get();
Review Comment:
This is an unexpected behavior, NPE in this case is better than nothing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
