[
https://issues.apache.org/jira/browse/GROOVY-11689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955710#comment-17955710
]
ASF GitHub Bot commented on GROOVY-11689:
-----------------------------------------
jdaugherty commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2931453412
I've made the requested change to only sort if there's > 1 entry in the list.
I also compiled with 4.0.27 and then with this change for the
grails-scaffolding project. Here's one example of the
GenerateAsyncControllerCommand.class and how this change affects it:
* https://gist.github.com/jdaugherty/e0f560faed06a75bcda12f01bda3aa14 -
4.0.27
* https://gist.github.com/jdaugherty/ef60dccc4682ab588b01e8d7d6761c48 -
Proposed Change
I've also additionally run the reproducible build test script in grails-core
and confirmed the differences drop off after this change. @eric-milles if you
have suggestions on how I could create an automated test for this, I'm happy to
pursue this too. I'm hoping the testing I've done on the grails-core project
would suffice though.
> @Delegate generates random method orders
> ----------------------------------------
>
> Key: GROOVY-11689
> URL: https://issues.apache.org/jira/browse/GROOVY-11689
> Project: Groovy
> Issue Type: Improvement
> Reporter: James Daugherty
> Priority: Major
>
> While working on the Grails build reproducibility, I discovered that the
> `grails-scaffolding` artifact was not reproducible. This was because the
> `@Delegate` method calls getMethods() which we discovered in GROOVY-11674 can
> have ordering issues. This ticket is to sort this call to ensure consistent
> class file creation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
