[
https://issues.apache.org/jira/browse/GROOVY-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955171#comment-17955171
] ASF GitHub Bot commented on GROOVY-11684: ----------------------------------------- codecov-commenter commented on PR #2241: URL: https://github.com/apache/groovy/pull/2241#issuecomment-2921871204 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 69.0438%. Comparing base [(`f229a1b`)](https://app.codecov.io/gh/apache/groovy/commit/f229a1b80e9bebbcd9bfc41865e477d981ca1fdc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b341b77`)](https://app.codecov.io/gh/apache/groovy/commit/b341b778d83ff65463a5b2e299b385302f8bed69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 2 commits behind head on master. <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2241 +/- ## ================================================== + Coverage 69.0354% 69.0438% +0.0084% - Complexity 29705 29711 +6 ================================================== Files 1423 1423 Lines 114421 114436 +15 Branches 19855 19859 +4 ================================================== + Hits 78991 79011 +20 + Misses 28790 28786 -4 + Partials 6640 6639 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2241?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...s/groovy/transform/ImmutableASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2241?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FImmutableASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9JbW11dGFibGVBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `66.8367% <100.0000%> (+0.6909%)` | :arrow_up: | | [...ovy/transform/MapConstructorASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2241?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FMapConstructorASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9NYXBDb25zdHJ1Y3RvckFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `82.3009% <100.0000%> (+0.4827%)` | :arrow_up: | | [...roovy/transform/NamedVariantASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2241?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FNamedVariantASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9OYW1lZFZhcmlhbnRBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `80.3798% <100.0000%> (+0.1250%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2241/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > The constructor produced by MapConstructor and the Immutable copyWith method > should include NamedParam information > ------------------------------------------------------------------------------------------------------------------ > > Key: GROOVY-11684 > URL: https://issues.apache.org/jira/browse/GROOVY-11684 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > > These are both methods that we generate that take a map argument (for Groovy > named parameters) and we know the valid names and types at the point of > generation, so we should include that. We already do that for the map > constructor produced for records. -- This message was sent by Atlassian Jira (v8.20.10#820010)
