Copilot commented on code in PR #2233:
URL: https://github.com/apache/groovy/pull/2233#discussion_r2105681783
##########
src/main/java/org/codehaus/groovy/vmplugin/v8/CacheableCallSite.java:
##########
@@ -119,6 +120,11 @@ public long incrementFallbackCount() {
public void resetFallbackCount() {
fallbackCount.set(0);
+ fallbackRound.incrementAndGet();
+ }
+
+ public AtomicLong getFallbackRound() {
Review Comment:
Consider returning a long value instead of exposing the AtomicLong directly.
This change would encapsulate the internal state better and reduce the risk of
unintended modifications by external callers.
##########
src/main/java/org/codehaus/groovy/vmplugin/v8/CacheableCallSite.java:
##########
@@ -119,6 +120,11 @@ public long incrementFallbackCount() {
public void resetFallbackCount() {
fallbackCount.set(0);
+ fallbackRound.incrementAndGet();
Review Comment:
[nitpick] Consider adding a comment to clarify the role of fallbackRound in
managing the fallback mechanism and its interaction with fallbackCount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
