[
https://issues.apache.org/jira/browse/GROOVY-11667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952290#comment-17952290
] ASF GitHub Bot commented on GROOVY-11667: ----------------------------------------- codecov-commenter commented on PR #2226: URL: https://github.com/apache/groovy/pull/2226#issuecomment-2887713384 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2226?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review. > Project coverage is 69.0242%. Comparing base [(`9299d69`)](https://app.codecov.io/gh/apache/groovy/commit/9299d69e9f420e5a76fa94d40d17afcdcd4d73cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ce20f1b`)](https://app.codecov.io/gh/apache/groovy/commit/ce20f1bdd5af922a34ae8afac4725bcbab5e629c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...in/java/groovy/xml/slurpersupport/GPathResult.java](https://app.codecov.io/gh/apache/groovy/pull/2226?src=pr&el=tree&filepath=subprojects%2Fgroovy-xml%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fxml%2Fslurpersupport%2FGPathResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXhtbC9zcmMvbWFpbi9qYXZhL2dyb292eS94bWwvc2x1cnBlcnN1cHBvcnQvR1BhdGhSZXN1bHQuamF2YQ==) | 50.0000% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2226 +/- ## ================================================== + Coverage 69.0228% 69.0242% +0.0014% - Complexity 29685 29686 +1 ================================================== Files 1423 1423 Lines 114342 114344 +2 Branches 19842 19842 ================================================== + Hits 78922 78925 +3 Misses 28786 28786 + Partials 6634 6633 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...in/java/groovy/xml/slurpersupport/GPathResult.java](https://app.codecov.io/gh/apache/groovy/pull/2226?src=pr&el=tree&filepath=subprojects%2Fgroovy-xml%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fxml%2Fslurpersupport%2FGPathResult.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXhtbC9zcmMvbWFpbi9qYXZhL2dyb292eS94bWwvc2x1cnBlcnN1cHBvcnQvR1BhdGhSZXN1bHQuamF2YQ==) | `82.2335% <50.0000%> (-0.8434%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > GPathResult and attribute syntax within inner class > --------------------------------------------------- > > Key: GROOVY-11667 > URL: https://issues.apache.org/jira/browse/GROOVY-11667 > Project: Groovy > Issue Type: Bug > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Major > > This came in through the mailing list. > {code:java} > @Test > void testAttribute() { > def xml = ''' > <person> > <name>John Doe</name> > </person> > ''' > def path = getRoot(xml) > def text = pa...@id.text() ?: null > assert text == null > assert new Inner(path).@id == null > } > static class Inner { > protected id > Inner(GPathResult gpath) { > this.@id = gpa...@id.text() ?: null > } > } > {code} > The problem has to do with the overloads of getAttribute and setAttribute. -- This message was sent by Atlassian Jira (v8.20.10#820010)
