[
https://issues.apache.org/jira/browse/GROOVY-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950550#comment-17950550
] ASF GitHub Bot commented on GROOVY-7439: ---------------------------------------- codecov-commenter commented on PR #2220: URL: https://github.com/apache/groovy/pull/2220#issuecomment-2866973382 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2220?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `95.00000%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 68.9951%. Comparing base [(`5916bc5`)](https://app.codecov.io/gh/apache/groovy/commit/5916bc5a57018c73247bb93b606dbef181fa729f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`1c21cf9`)](https://app.codecov.io/gh/apache/groovy/commit/1c21cf936b34899f513fd311995f9af1c9a4499d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2220?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ansform/ASTTransformationCollectorCodeVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FASTTransformationCollectorCodeVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9BU1RUcmFuc2Zvcm1hdGlvbkNvbGxlY3RvckNvZGVWaXNpdG9yLmphdmE=) | 75.0000% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2220 +/- ## ================================================== + Coverage 68.9931% 68.9951% +0.0020% - Complexity 29660 29665 +5 ================================================== Files 1423 1423 Lines 114323 114327 +4 Branches 19832 19832 ================================================== + Hits 78875 78880 +5 - Misses 28815 28816 +1 + Partials 6633 6631 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2220?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...aus/groovy/transform/ASTTransformationVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FASTTransformationVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9BU1RUcmFuc2Zvcm1hdGlvblZpc2l0b3IuamF2YQ==) | `81.8182% <100.0000%> (ø)` | | | [...aus/groovy/transform/BuilderASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FBuilderASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9CdWlsZGVyQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `62.8571% <100.0000%> (ø)` | | | [...ransform/ExternalizeVerifierASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FExternalizeVerifierASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9FeHRlcm5hbGl6ZVZlcmlmaWVyQVNUVHJhbnNmb3JtYXRpb24uamF2YQ==) | `92.1053% <100.0000%> (ø)` | | | [...odehaus/groovy/transform/LogASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FLogASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9Mb2dBU1RUcmFuc2Zvcm1hdGlvbi5qYXZh) | `68.0672% <100.0000%> (+0.2706%)` | :arrow_up: | | [...us/groovy/transform/SortableASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FSortableASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9Tb3J0YWJsZUFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `96.7742% <ø> (ø)` | | | [...groovy/transform/trait/TraitASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Ftrait%2FTraitASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS90cmFpdC9UcmFpdEFTVFRyYW5zZm9ybWF0aW9uLmphdmE=) | `90.9375% <100.0000%> (ø)` | | | [...ansform/ASTTransformationCollectorCodeVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2220?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2FASTTransformationCollectorCodeVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9BU1RUcmFuc2Zvcm1hdGlvbkNvbGxlY3RvckNvZGVWaXNpdG9yLmphdmE=) | `91.5584% <75.0000%> (-1.8190%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2220/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Compilation errors using groovy trait and @CompileStatic and @Slf4j("LOG") > -------------------------------------------------------------------------- > > Key: GROOVY-7439 > URL: https://issues.apache.org/jira/browse/GROOVY-7439 > Project: Groovy > Issue Type: Bug > Components: Compiler > Affects Versions: 2.4.3 > Reporter: Allen Arakaki > Assignee: Eric Milles > Priority: Major > Labels: trait, traits > > Compilation errors using groovy trait and @CompileStatic and @Slf4j("LOG") > Easy to reproduce: > ------------------------------------------------ > {code} > import org.slf4j.Logger > import groovy.transform.CompileStatic > import groovy.util.logging.Slf4j > @Slf4j("LOG") > @CompileStatic > trait TTest { > void test1() { > LOG.debug("Logging test1 ...") > } > void test2() { > //((Logger)LOG).debug("Logging test2 ...") > } > } > {code} > Results in the following: > | Error Compilation error: startup failed: > ..\src\groovy\TTest.groovy: 10: [Static type checking] - Cannot find matching > method java.lang.Object#debug(java.lang.String). Please check if the declared > type is right and if the method exists. > @ line 10, column 5. > LOG.debug("Logging test1 ...") > ^ > {code} > import org.slf4j.Logger > import groovy.transform.CompileStatic > import groovy.util.logging.Slf4j > @Slf4j("LOG") > @CompileStatic > trait TTest { > void test1() { > //LOG.debug("Logging test1 ...") > } > void test2() { > ((Logger)LOG).debug("Logging test2 ...") > } > } > {code} > Results in the following error: > | Error Compilation error: startup failed: > ..\src\groovy\TTest.groovy: -1: Access to TTest#LOG is forbidden @ line -1, > column -1. -- This message was sent by Atlassian Jira (v8.20.10#820010)
