[
https://issues.apache.org/jira/browse/GROOVY-11654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949711#comment-17949711
]
ASF GitHub Bot commented on GROOVY-11654:
-----------------------------------------
codecov-commenter commented on PR #2214:
URL: https://github.com/apache/groovy/pull/2214#issuecomment-2854406649
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2214?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `88.88889%` with `9 lines` in your changes
missing coverage. Please review.
> Project coverage is 69.0036%. Comparing base
[(`f1b3f72`)](https://app.codecov.io/gh/apache/groovy/commit/f1b3f727ed9a94ab314241449ae875cf7355ffe8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`c954185`)](https://app.codecov.io/gh/apache/groovy/commit/c9541854ec5ca595478c465786e1d4ade429e4ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2214?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2214?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=)
| 88.8889% | [0 Missing and 9 partials :warning:
](https://app.codecov.io/gh/apache/groovy/pull/2214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/groovy/pull/2214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #2214 +/- ##
==================================================
+ Coverage 68.9851% 69.0036% +0.0185%
- Complexity 29623 29654 +31
==================================================
Files 1423 1423
Lines 114216 114297 +81
Branches 19810 19828 +18
==================================================
+ Hits 78792 78869 +77
+ Misses 28803 28800 -3
- Partials 6621 6628 +7
```
| [Files with missing
lines](https://app.codecov.io/gh/apache/groovy/pull/2214?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2214?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=)
| `89.1892% <88.8889%> (-0.0157%)` | :arrow_down: |
... and [2 files with indirect coverage
changes](https://app.codecov.io/gh/apache/groovy/pull/2214/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Create AGM#putAt variants
> -------------------------
>
> Key: GROOVY-11654
> URL: https://issues.apache.org/jira/browse/GROOVY-11654
> Project: Groovy
> Issue Type: New Feature
> Reporter: Paul King
> Assignee: Paul King
> Priority: Major
>
> When creating potential examples for the Groovy 5 release notes, I created
> this example:
> {code:groovy}
> // keep top 5 scores in top array
> int[] scores = [56, 82, 70, 74, 63, 92, 49, 69, 85, 79, 80, 82, 99, 95]
> int[] top = scores[0..4].sort()
> scores[5..-1].each { next ->
> def ins = top.partitionPoint{ it < next } - 1
> if (ins > 0) {
> System.arraycopy(top, 1, top, 0, ins)
> // top[0..<ins] = top[1..ins]
> }
> if (ins >= 0) {
> top[ins] = next
> }
> }
> assert top == [82, 85, 92, 95, 99]
> {code}
> The {{System.arraycopy()}} line would be {{top[0..<ins] = top[1..ins]}} if
> using lists. It would be nice if arrays supported putAt and that line didn't
> need to change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
