[
https://issues.apache.org/jira/browse/GROOVY-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948619#comment-17948619
] ASF GitHub Bot commented on GROOVY-11647: ----------------------------------------- codecov-commenter commented on PR #2209: URL: https://github.com/apache/groovy/pull/2209#issuecomment-2844073448 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `86.66667%` with `4 lines` in your changes missing coverage. Please review. > Project coverage is 68.9519%. Comparing base [(`889a1cb`)](https://app.codecov.io/gh/apache/groovy/commit/889a1cb53ac9540b9b1b76fe59f212c9f4c3b60f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5c50aba`)](https://app.codecov.io/gh/apache/groovy/commit/5c50aba56d0cd2c4053557106d78127d07f56823?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2209?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2209?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | 86.2069% | [3 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2209 +/- ## ================================================== - Coverage 68.9525% 68.9519% -0.0006% + Complexity 29588 29586 -2 ================================================== Files 1423 1423 Lines 114006 114020 +14 Branches 19783 19785 +2 ================================================== + Hits 78610 78619 +9 - Misses 28785 28788 +3 - Partials 6611 6613 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2209?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2209?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `88.6884% <100.0000%> (ø)` | | | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2209?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FDefaultGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | `74.1847% <86.2069%> (+0.0800%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2209/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Change return type of DGM#findIndexValues(Iterator) methods > ----------------------------------------------------------- > > Key: GROOVY-11647 > URL: https://issues.apache.org/jira/browse/GROOVY-11647 > Project: Groovy > Issue Type: Improvement > Reporter: Paul King > Assignee: Paul King > Priority: Major > Labels: breaking > > Original discussion: > https://lists.apache.org/thread/xv1bpgc7xp3rwp7qt627xfyd10ljcwbc > This issue is splitting out the {{findIndexValues}} methods. Rather than > creating {{findingIndexValues}} methods, we think the Iterator variant of > this method is used rarely enough that giving it the same treatment as > {{chop}} by changing the return type and providing a bridge method is the > better path. > There are two cases to consider: > # When the findIndexValues call is followed by some other chained calls (or > calls in subsequent statements), there will typically be no change needed, > assuming some terminal-like operator is eventually in the chain of calls. > # When the findIndexValues call is last, calls like "iter.findIndexValues()" > would need to change to "iter.toList().findIndexValues()" or > "iter.findIndexValues().toList()". -- This message was sent by Atlassian Jira (v8.20.10#820010)
