[ 
https://issues.apache.org/jira/browse/GROOVY-11636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946941#comment-17946941
 ] 

ASF GitHub Bot commented on GROOVY-11636:
-----------------------------------------

codecov-commenter commented on PR #2204:
URL: https://github.com/apache/groovy/pull/2204#issuecomment-2826464638

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2204?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `46.15385%` with `7 lines` in your changes 
missing coverage. Please review.
   > Project coverage is 68.9424%. Comparing base 
[(`d77d909`)](https://app.codecov.io/gh/apache/groovy/commit/d77d909df28896a21fe4958a201f98c891d5cb51?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`8f42086`)](https://app.codecov.io/gh/apache/groovy/commit/8f42086761d00e93b0779bcc9a9e7b600bec51a6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2204?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...g/codehaus/groovy/runtime/StringGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2204?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FStringGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU3RyaW5nR3Jvb3Z5TWV0aG9kcy5qYXZh)
 | 46.1538% | [4 Missing and 3 partials :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2204/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2204?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2204        +/-   ##
   ==================================================
   - Coverage     68.9476%   68.9424%   -0.0052%     
   - Complexity      29560      29563         +3     
   ==================================================
     Files            1423       1423                
     Lines          113914     113927        +13     
     Branches        19756      19759         +3     
   ==================================================
   + Hits            78541      78544         +3     
   - Misses          28775      28781         +6     
   - Partials         6598       6602         +4     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2204?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...g/codehaus/groovy/runtime/StringGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2204?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FStringGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU3RyaW5nR3Jvb3Z5TWV0aG9kcy5qYXZh)
 | `84.0268% <46.1538%> (-0.6726%)` | :arrow_down: |
   
   ... and [4 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2204/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Create a SGM#next which also takes an integer increment value
> -------------------------------------------------------------
>
>                 Key: GROOVY-11636
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11636
>             Project: Groovy
>          Issue Type: New Feature
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>
> Trying to get from String 'a' to 'e' by "adding 4" can be cumbersome, either 
> calling next() multiple times, or converting to a char, doing the arithmetic, 
> then converting back.
> The idea would be to support:
> {code:groovy}
> assert 'a'.next(0) == 'a'
> assert 'a'.next(4) == 'e'
> assert 'a'.next(0) == 'a'
> assert 'a'.next(25) == 'z'
> assert 'A'.next(32) == 'a'
> assert (0..4).collect('a'::next) == 'a'..'e'
> assert 'car'.next(2) == 'cat'
> {code}
> Although hopefully never used, this piggybacks on the normal next() wrapping 
> behavior if Character.MAX_VALUE is reached. And also, like next(), applies 
> the the last character in a longer String as per last test above.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to