[ 
https://issues.apache.org/jira/browse/GROOVY-11600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941185#comment-17941185
 ] 

ASF GitHub Bot commented on GROOVY-11600:
-----------------------------------------

codecov-commenter commented on PR #2176:
URL: https://github.com/apache/groovy/pull/2176#issuecomment-2780153766

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2176?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 68.8725%. Comparing base 
[(`876fbed`)](https://app.codecov.io/gh/apache/groovy/commit/876fbed302a2e92d572d6c01ce4f134c712cb1c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`e41aff7`)](https://app.codecov.io/gh/apache/groovy/commit/e41aff7071b1d281ad02b354f3633010e13612fc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2176/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2176        +/-   ##
   ==================================================
   + Coverage     68.8710%   68.8725%   +0.0015%     
   - Complexity      29570      29575         +5     
   ==================================================
     Files            1421       1421                
     Lines          113714     113713         -1     
     Branches        19715      19716         +1     
   ==================================================
   + Hits            78316      78317         +1     
     Misses          28787      28787                
   + Partials         6611       6609         -2     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2176?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==)
 | `86.3111% <100.0000%> (-0.0122%)` | :arrow_down: |
   | 
[...ain/java/org/codehaus/groovy/antlr/EnumHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fantlr%2FEnumHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FudGxyL0VudW1IZWxwZXIuamF2YQ==)
 | `93.7500% <100.0000%> (ø)` | |
   | 
[...n/java/org/codehaus/groovy/ast/InnerClassNode.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fast%2FInnerClassNode.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2FzdC9Jbm5lckNsYXNzTm9kZS5qYXZh)
 | `88.8889% <100.0000%> (ø)` | |
   | 
[...java/org/codehaus/groovy/classgen/EnumVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FEnumVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0VudW1WaXNpdG9yLmphdmE=)
 | `92.0000% <ø> (-0.0530%)` | :arrow_down: |
   | 
[...ehaus/groovy/classgen/InnerClassVisitorHelper.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2FInnerClassVisitorHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL0lubmVyQ2xhc3NWaXNpdG9ySGVscGVyLmphdmE=)
 | `96.1538% <100.0000%> (+0.1539%)` | :arrow_up: |
   | 
[...groovy/transform/trait/TraitASTTransformation.java](https://app.codecov.io/gh/apache/groovy/pull/2176?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Ftrait%2FTraitASTTransformation.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS90cmFpdC9UcmFpdEFTVFRyYW5zZm9ybWF0aW9uLmphdmE=)
 | `90.9375% <100.0000%> (+0.0284%)` | :arrow_up: |
   
   ... and [6 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2176/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Static compiler should treat inner records as static
> ----------------------------------------------------
>
>                 Key: GROOVY-11600
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11600
>             Project: Groovy
>          Issue Type: Bug
>          Components: Static compilation, Static Type Checker
>    Affects Versions: 4.0.25, 4.0.26
>            Reporter: Leonard Brünings
>            Assignee: Eric Milles
>            Priority: Major
>
> {code:title=should work|language=groovy}
> @groovy.transform.CompileStatic
> class Reproducer { 
>   def foo() {
>     new MyRecord(42)
>   } 
>  record MyRecord(int i) {}
> }
> {code}
> But fails with {{[Static type checking] - Cannot find matching constructor 
> Reproducer$MyRecord(Reproducer, int)}}
> These work
> {code:title=static record|language=groovy}
> @groovy.transform.CompileStatic
> class Reproducer { 
>   def foo() {
>     new MyRecord(42)
>   } 
>   static record MyRecord(int i) {}
> }
> {code}
> {code:title=static method|language=groovy}
> @groovy.transform.CompileStatic
> class Reproducer { 
>   static def foo() {
>     new MyRecord(42)
>   } 
>   record MyRecord(int i) {}
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to