[
https://issues.apache.org/jira/browse/GROOVY-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941076#comment-17941076
] ASF GitHub Bot commented on GROOVY-11601: ----------------------------------------- codecov-commenter commented on PR #2174: URL: https://github.com/apache/groovy/pull/2174#issuecomment-2779715333 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2174?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 68.8764%. Comparing base [(`876fbed`)](https://app.codecov.io/gh/apache/groovy/commit/876fbed302a2e92d572d6c01ce4f134c712cb1c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6237562`)](https://app.codecov.io/gh/apache/groovy/commit/62375622dbc7629783cb6a8fa872eedd8dea2209?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2174 +/- ## ================================================== + Coverage 68.8710% 68.8764% +0.0053% + Complexity 29570 29569 -1 ================================================== Files 1421 1421 Lines 113714 113711 -3 Branches 19715 19714 -1 ================================================== + Hits 78316 78320 +4 + Misses 28787 28783 -4 + Partials 6611 6608 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2174?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...va/org/apache/groovy/parser/antlr4/AstBuilder.java](https://app.codecov.io/gh/apache/groovy/pull/2174?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fapache%2Fgroovy%2Fparser%2Fantlr4%2FAstBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9wYXJzZXIvYW50bHI0L0FzdEJ1aWxkZXIuamF2YQ==) | `86.3495% <100.0000%> (+0.0262%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > remove support for expression list in for-each statement > -------------------------------------------------------- > > Key: GROOVY-11601 > URL: https://issues.apache.org/jira/browse/GROOVY-11601 > Project: Groovy > Issue Type: Improvement > Components: parser-antlr4 > Reporter: Eric Milles > Assignee: Eric Milles > Priority: Minor > > The for-each loop supports an arbitrary expression list. Presumably this is > for legacy reasons. Now that multi-variable declaration is supported by > for-each and classic for, it does not seem necessary to support expression > list. I propose to remove it from the parser grammar. -- This message was sent by Atlassian Jira (v8.20.10#820010)
