[
https://issues.apache.org/jira/browse/GROOVY-11539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909162#comment-17909162
] ASF GitHub Bot commented on GROOVY-11539: ----------------------------------------- codecov-commenter commented on PR #2137: URL: https://github.com/apache/groovy/pull/2137#issuecomment-2567176653 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `42.85714%` with `32 lines` in your changes missing coverage. Please review. > Project coverage is 68.8349%. Comparing base [(`b0fcd1b`)](https://app.codecov.io/gh/apache/groovy/commit/b0fcd1bae879aa1c1983d341d56b58eb3a5e8dec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fd51528`)](https://app.codecov.io/gh/apache/groovy/commit/fd515288653dfbe53ed833e929cb46263d36e118?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2137?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | 47.0588% | [26 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/groovy/util/function/FloatUnaryOperator.java](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Futil%2Ffunction%2FFloatUnaryOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdXRpbC9mdW5jdGlvbi9GbG9hdFVuYXJ5T3BlcmF0b3IuamF2YQ==) | 0.0000% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2137 +/- ## ================================================== - Coverage 68.8433% 68.8349% -0.0084% - Complexity 29412 29424 +12 ================================================== Files 1419 1420 +1 Lines 113064 113117 +53 Branches 19531 19543 +12 ================================================== + Hits 77837 77864 +27 - Misses 28684 28713 +29 + Partials 6543 6540 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2137?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../java/groovy/util/function/FloatUnaryOperator.java](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Futil%2Ffunction%2FFloatUnaryOperator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvdXRpbC9mdW5jdGlvbi9GbG9hdFVuYXJ5T3BlcmF0b3IuamF2YQ==) | `0.0000% <0.0000%> (ø)` | | | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://app.codecov.io/gh/apache/groovy/pull/2137?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FArrayGroovyMethods.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `90.8819% <47.0588%> (-1.7537%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > float variants for min/max in ArrayGroovyMethods > ------------------------------------------------ > > Key: GROOVY-11539 > URL: https://issues.apache.org/jira/browse/GROOVY-11539 > Project: Groovy > Issue Type: New Feature > Reporter: Paul King > Priority: Major > > In general, you are recommended to use double vs float but we may as well > provide min/max for float because some folks use floats anyway. I recently > came across this using dl4j with a pytorch model. -- This message was sent by Atlassian Jira (v8.20.10#820010)
