[ 
https://issues.apache.org/jira/browse/GROOVY-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17907072#comment-17907072
 ] 

ASF GitHub Bot commented on GROOVY-11190:
-----------------------------------------

codecov-commenter commented on PR #2136:
URL: https://github.com/apache/groovy/pull/2136#issuecomment-2554501476

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2136?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: Patch coverage is `22.22222%` with `7 lines` in your changes 
missing coverage. Please review.
   > Project coverage is 68.8508%. Comparing base 
[(`9131ca7`)](https://app.codecov.io/gh/apache/groovy/commit/9131ca7ab3305ed690a78cfef56248b837c6b1ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`4855e43`)](https://app.codecov.io/gh/apache/groovy/commit/4855e4312ebe29d50dc36b2a19609fe0df767799?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2136?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[.../main/java/groovy/servlet/AbstractHttpServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FAbstractHttpServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9BYnN0cmFjdEh0dHBTZXJ2bGV0LmphdmE=)
 | 25.0000% | [2 Missing and 1 partial :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[...et/src/main/java/groovy/servlet/GroovyServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FGroovyServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9Hcm9vdnlTZXJ2bGV0LmphdmE=)
 | 0.0000% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   | 
[.../src/main/java/groovy/servlet/TemplateServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FTemplateServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9UZW1wbGF0ZVNlcnZsZXQuamF2YQ==)
 | 0.0000% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2136/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2136        +/-   ##
   ==================================================
   + Coverage     68.8425%   68.8508%   +0.0083%     
   - Complexity      29418      29419         +1     
   ==================================================
     Files            1419       1419                
     Lines          113061     113059         -2     
     Branches        19530      19530                
   ==================================================
   + Hits            77834      77842         +8     
   + Misses          28685      28678         -7     
   + Partials         6542       6539         -3     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2136?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[...t/src/main/java/groovy/servlet/ServletBinding.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FServletBinding.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9TZXJ2bGV0QmluZGluZy5qYXZh)
 | `61.4286% <100.0000%> (-0.7143%)` | :arrow_down: |
   | 
[.../src/main/java/groovy/servlet/ServletCategory.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FServletCategory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9TZXJ2bGV0Q2F0ZWdvcnkuamF2YQ==)
 | `0.0000% <ø> (ø)` | |
   | 
[.../src/main/java/groovy/servlet/TemplateServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FTemplateServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9UZW1wbGF0ZVNlcnZsZXQuamF2YQ==)
 | `39.4366% <0.0000%> (ø)` | |
   | 
[.../main/java/groovy/servlet/AbstractHttpServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FAbstractHttpServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9BYnN0cmFjdEh0dHBTZXJ2bGV0LmphdmE=)
 | `57.8947% <25.0000%> (-0.7260%)` | :arrow_down: |
   | 
[...et/src/main/java/groovy/servlet/GroovyServlet.java](https://app.codecov.io/gh/apache/groovy/pull/2136?src=pr&el=tree&filepath=subprojects%2Fgroovy-servlet%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fservlet%2FGroovyServlet.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNlcnZsZXQvc3JjL21haW4vamF2YS9ncm9vdnkvc2VydmxldC9Hcm9vdnlTZXJ2bGV0LmphdmE=)
 | `0.0000% <0.0000%> (ø)` | |
   
   ... and [3 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2136/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>




> Jakarta EE 9 compatibility for groovy-servlet
> ---------------------------------------------
>
>                 Key: GROOVY-11190
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11190
>             Project: Groovy
>          Issue Type: Question
>    Affects Versions: 5.0.0-alpha-2
>            Reporter: Oleg K.
>            Assignee: Paul King
>            Priority: Major
>             Fix For: 5.x
>
>
> Greetings, Groovy Team!
> The groovy project depends on javaxServletApi 4.0.1 specifically needed for 
> groovy-servlet subproject.
> The implementation matches Servlet 4 spec, part of Jakarta EE 8.
> When moving to Jakarta EE 9 webserver, the spec updates to Servlet 5.
> The new spec brings a backward incompatible change in namespaces, from 
> javax.* to jakarta.*.
> More info here: [https://jakarta.ee/specifications/servlet/]
> This needs to be reflected in a code of groovy-servlet subproject.
> For example:
> {code:java}
> import javax.servlet.http.HttpServlet;
> {code}
> becomes
> {code:java}
> import jakarta.servlet.http.HttpServlet;
> {code}
> Please advise, is there a plan to start building groovy-servlet aligned with 
> the new spec in the upcoming 5.0.0 release?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to