[
https://issues.apache.org/jira/browse/GROOVY-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904377#comment-17904377
] ASF GitHub Bot commented on GROOVY-8283: ---------------------------------------- codecov-commenter commented on PR #1767: URL: https://github.com/apache/groovy/pull/1767#issuecomment-2530651240 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `84.61538%` with `4 lines` in your changes missing coverage. Please review. > Project coverage is 68.8510%. Comparing base [(`6cd477b`)](https://app.codecov.io/gh/apache/groovy/commit/6cd477b3157675f0ceee9fbd62e3efd0cc9bdb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`a9a1fc4`)](https://app.codecov.io/gh/apache/groovy/commit/a9a1fc44774a3e311d9c7a709e899c03affbcbaf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 387 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | 81.8182% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ovy/classgen/asm/sc/StaticTypesCallSiteWriter.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticTypesCallSiteWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNUeXBlc0NhbGxTaXRlV3JpdGVyLmphdmE=) | 60.0000% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #1767 +/- ## ================================================== + Coverage 68.5957% 68.8510% +0.2553% - Complexity 29233 29430 +197 ================================================== Files 1426 1419 -7 Lines 113494 113076 -418 Branches 19548 19532 -16 ================================================== + Hits 77852 77854 +2 + Misses 29088 28681 -407 + Partials 6554 6541 -13 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/1767?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...codehaus/groovy/runtime/ScriptBytecodeAdapter.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fruntime%2FScriptBytecodeAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU2NyaXB0Qnl0ZWNvZGVBZGFwdGVyLmphdmE=) | `69.9266% <100.0000%> (+1.9266%)` | :arrow_up: | | [...roovy/transform/stc/StaticTypeCheckingVisitor.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Ftransform%2Fstc%2FStaticTypeCheckingVisitor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3RyYW5zZm9ybS9zdGMvU3RhdGljVHlwZUNoZWNraW5nVmlzaXRvci5qYXZh) | `87.7228% <100.0000%> (-0.0412%)` | :arrow_down: | | [src/main/java/groovy/lang/MetaClassImpl.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FMetaClassImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9NZXRhQ2xhc3NJbXBsLmphdmE=) | `77.8693% <81.8182%> (+1.2829%)` | :arrow_up: | | [...ovy/classgen/asm/sc/StaticTypesCallSiteWriter.java](https://app.codecov.io/gh/apache/groovy/pull/1767?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fclassgen%2Fasm%2Fsc%2FStaticTypesCallSiteWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9zYy9TdGF0aWNUeXBlc0NhbGxTaXRlV3JpdGVyLmphdmE=) | `73.8683% <60.0000%> (+5.6143%)` | :arrow_up: | ... and [117 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/1767/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> > Field shadowing not considered in STC > ------------------------------------- > > Key: GROOVY-8283 > URL: https://issues.apache.org/jira/browse/GROOVY-8283 > Project: Groovy > Issue Type: Bug > Components: Static compilation, Static Type Checker > Affects Versions: 2.4.12 > Reporter: Daniil Ovchinnikov > Assignee: Eric Milles > Priority: Major > Labels: breaking > > {code} > import groovy.transform.CompileStatic > @CompileStatic class A {} > @CompileStatic class B {} > @CompileStatic class Parent { > protected A ff = new A() > A getFf() { ff } > } > @CompileStatic class Child extends Parent { > protected B ff = new B() > } > @CompileStatic class Usage extends Child { > def test() { > println ff // A@id > println getFf() // A@id > println this.@ff // B@id > } > def test2() { > I.wantsB(ff) // > ScriptBytecodeAdapter.castToType(((Usage)this).getFf(), B.class)) is > generated (wrong) > I.wantsB(getFf()) // [STC] - Cannot find matching method I#wantsB(A) > I.wantsB(this.@ff) // [STC] - Cannot find matching method I#wantsB(A) > (wrong) > } > } > @CompileStatic class I { > static void wantsB(B b) {} > } > new Usage().test() > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)
