[ 
https://issues.apache.org/jira/browse/GROOVY-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881895#comment-17881895
 ] 

ASF GitHub Bot commented on GROOVY-11478:
-----------------------------------------

codecov-commenter commented on PR #2114:
URL: https://github.com/apache/groovy/pull/2114#issuecomment-2351937185

   ## 
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2114?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 68.6758%. Comparing base 
[(`6cd477b`)](https://app.codecov.io/gh/apache/groovy/commit/6cd477b3157675f0ceee9fbd62e3efd0cc9bdb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`4ee5147`)](https://app.codecov.io/gh/apache/groovy/commit/4ee5147b684c399ba3c00205b8d6b0255d3bb147?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 243 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree 
graph](https://app.codecov.io/gh/apache/groovy/pull/2114/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2114        +/-   ##
   ==================================================
   + Coverage     68.5957%   68.6758%   +0.0801%     
   - Complexity      29233      29391       +158     
   ==================================================
     Files            1426       1426                
     Lines          113494     113583        +89     
     Branches        19548      19583        +35     
   ==================================================
   + Hits            77852      78004       +152     
   + Misses          29088      29037        -51     
   + Partials         6554       6542        -12     
   ```
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/groovy/pull/2114?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[src/main/java/groovy/lang/GroovyClassLoader.java](https://app.codecov.io/gh/apache/groovy/pull/2114?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Fgroovy%2Flang%2FGroovyClassLoader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vamF2YS9ncm9vdnkvbGFuZy9Hcm9vdnlDbGFzc0xvYWRlci5qYXZh)
 | `71.6216% <100.0000%> (+0.1148%)` | :arrow_up: |
   
   ... and [53 files with indirect coverage 
changes](https://app.codecov.io/gh/apache/groovy/pull/2114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>




> Enable GroovyClassLoader to be ParallelCapable
> ----------------------------------------------
>
>                 Key: GROOVY-11478
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11478
>             Project: Groovy
>          Issue Type: Improvement
>    Affects Versions: 3.0.22, 4.0.23, 5.0.0-alpha-10
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>
> GroovyClassLoader is parallel capable but we do not declare it as such by 
> calling the {{registerAsParallelCapable}} method as per recommended 
> guidelines[1]. Some frameworks have worked around this using reflection but 
> as JDK restrictions have tightened in later JDK versions, this has become not 
> possible. Other workarounds[2] for frameworks to work with non-parallel 
> capable classloaders have also been deprecated and removed in recent JDK 
> versions[3][4][5]. See also [6].
> [1] https://docs.oracle.com/javase/7/docs/technotes/guides/lang/cl-mt.html
> [2] https://openjdk.org/groups/core-libs/ClassLoaderProposal.html
> [3] https://bugs.openjdk.org/browse/JDK-8296446
> [4] https://bugs.openjdk.org/browse/JDK-8303967
> [5] https://bugs.openjdk.org/browse/JDK-8295848
> [6] https://inside.java/2022/11/14/quality-heads-up/



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to