[ 
https://issues.apache.org/jira/browse/GROOVY-11260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801272#comment-17801272
 ] 

ASF GitHub Bot commented on GROOVY-11260:
-----------------------------------------

paulk-asert commented on PR #2022:
URL: https://github.com/apache/groovy/pull/2022#issuecomment-1872397053

   It currently doesn't check whether the placeholder names and 
varargPlaceholder names are distinct. It may not matter but code with such name 
clashes might become harder to understand, so maybe we should just rule it out.
   
   Also, it currently just matches against all arguments - rather than allowing 
some normal args followed by the varargs pattern. I'd prefer the latter but it 
adds much more complexity and the examples where I am using this haven't 
required this functionality yet. It should be backwards compatible to add such 
functionality later.




> ASTMatcher should support matching a var-arg placeholder
> --------------------------------------------------------
>
>                 Key: GROOVY-11260
>                 URL: https://issues.apache.org/jira/browse/GROOVY-11260
>             Project: Groovy
>          Issue Type: New Feature
>            Reporter: Paul King
>            Assignee: Paul King
>            Priority: Major
>
> Currently the ASTMatcher supports having a wildcard or placeholder term 
> within the AST tree pattern but it is cumbersome to do matching on a method 
> call that contains var-args.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to