blackdrag commented on a change in pull request #1173: GROOVY-9211: BUG!
UNCAUGHT EXCEPTION on OpenJDK14-ea+8
URL: https://github.com/apache/groovy/pull/1173#discussion_r384098562
##########
File path: src/test/groovy/lang/ScriptSourcePositionInAstTest.groovy
##########
@@ -45,18 +46,24 @@ class ScriptSourcePositionInAstTest extends GroovyTestCase
{
}
void testDoubleStatementScript() {
- assert positionsForScript("""\
+ def raw = """\
println 'hello'
println 'bye'
- """.stripIndent()) == [[1, 1], [2, 14]]
+ """
+ // avoid stripIndent issues on JDK13+ by calling Groovy's DGM
stripIndent explicitly
+ def script = StringGroovyMethods.stripIndent((CharSequence)raw)
Review comment:
if it is going to stay then we need to think about how the two stripidents
differ and what we do about it. We may have to remove our stripident in general
for example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
