danielsun1106 commented on a change in pull request #1171: GROOVY-9416: Avoid
unnecessary looking up non default import classes …
URL: https://github.com/apache/groovy/pull/1171#discussion_r382994421
##########
File path: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java
##########
@@ -106,6 +141,15 @@
return result;
}
+ @Override
+ public boolean resolveFromDefaultImports(ResolveVisitor resolveVisitor,
final ClassNode type) {
Review comment:
> In fact we should move them out there as much as possible.
Understood. We use `ClassFinder` to find default imported classes within JRT
as well, but visiting JRT is only available in Java 9+ :-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
