jdaugherty commented on code in PR #15382:
URL: https://github.com/apache/grails-core/pull/15382#discussion_r2924581972
##########
grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy:
##########
@@ -229,14 +229,18 @@ class GrailsGradlePlugin implements Plugin<Project> {
// Configure indy and log status after evaluation so user's grails { }
block has been applied
project.afterEvaluate {
boolean indyEnabled = grailsExtension?.indy?.getOrElse(false) ?:
false
+ boolean preserveParameterNames =
grailsExtension?.preserveParameterNames != null
+ ? grailsExtension.preserveParameterNames.getOrElse(true) : true
project.tasks.withType(GroovyCompile).configureEach {
GroovyCompile c ->
c.groovyOptions.optimizationOptions.indy = indyEnabled
+ c.groovyOptions.parameters = preserveParameterNames
Review Comment:
We should support a null value on this field so we can let an external
process configure this. The grails plugin is meant to be a configuration over
convention - meaning, it's possible to override to the original value and not
assume simple true/false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
