The GitHub Actions job "CI - Groovy Joint Validation Build" on 
grails-core.git/refactor/remove-gorm-enhancer-from-tests has failed.
Run started by GitHub user jamesfredley (triggered by jamesfredley).

Head commit for run:
be27f2b6ca2134f62629f6d2e3e9c2a283ccedff / James Fredley 
<[email protected]>
refactor(tests): replace GormEnhancer.find*Api calls with public GORM APIs

Tests were calling GormEnhancer.findStaticApi(), findInstanceApi(), and
findValidationApi() to interact with GORM internals directly. Replace all
usages with the same public APIs an end user would call.

Changes per file:
- WhereQueryConnectionRoutingSpec: use Domain."${connectionName}"
  named-datasource property + instance .save()/.delete() directly
- FooIntegrationSpec / BarIntegrationSpec: use Domain.withNewSession
  to access the backing datastore
- SaveWithFailOnErrorDefaultSpec: remove mutation of internal failOnError
  state; test per-call save(failOnError: true/false) behaviour instead
- DeepValidateWithSaveSpec: drop GormInstanceApi mock; use real entity
  with entity.save(deepValidate: true/false)
- DataServiceMultiTenantMultiDataSourceSpec: replace API-registration
  assertion with functional save/count via data service; replace
  GormEnhancer in MetricService with Metric.executeQuery/executeUpdate
  (safe because the service is @Transactional(connection='analytics'))
- DataServiceMultiDataSourceSpec: add @Query deleteAll()/getTotalAmount()
  to ProductService; replace all GormEnhancer calls with data service
  and domain static methods
- ValidationSpec (neo4j): use mappingContext.addEntityValidator(entity, null)
  to clear validators instead of GormEnhancer.findValidationApi()

All affected tests pass.

Assisted-by: Claude Code <[email protected]>

Report URL: https://github.com/apache/grails-core/actions/runs/22331773669

With regards,
GitHub Actions via GitBox

Reply via email to