utafrali commented on PR #16128: URL: https://github.com/apache/dubbo/pull/16128#issuecomment-4249987087
Thanks for the pointer to #16132 — the adapter approach there is more thorough than what I have here. Just to clarify the scope of this PR in case it's useful: it doesn't drop PushGateway support. It only stops requiring the PushGateway classes inside `MetricsSupportUtil.isSupportPrometheus()` and wraps the initializer in a `NoClassDefFoundError` catch, so scrape-only setups stop silently failing when PushGateway isn't on the classpath. When the PushGateway deps are present it still initializes the exporter normally. That said, #16132 covers proper dual-stack detection and both legacy/new PushGateway paths, which supersedes this. If that one lands I'm happy to close this out; leaving it open for now only in case a smaller interim patch is useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
