Alanxtl commented on code in PR #3285:
URL: https://github.com/apache/dubbo-go/pull/3285#discussion_r3051551055
##########
protocol/triple/triple_invoker.go:
##########
@@ -202,18 +212,8 @@ func parseInvocation(ctx context.Context, url *common.URL,
invocation base.Invoc
return callType, inRaw, method, nil
}
-// parseAttachments retrieves attachments from users passed-in and URL, then
injects them into ctx
+// parseAttachments injects pre-defined URL attachments into invocation.
func parseAttachments(ctx context.Context, url *common.URL, invocation
base.Invocation) {
- // retrieve users passed-in attachment
- attaRaw := ctx.Value(constant.AttachmentKey)
- if attaRaw != nil {
- if userAtta, ok := attaRaw.(map[string]any); ok {
- for key, val := range userAtta {
- invocation.SetAttachment(key, val)
- }
- }
- }
Review Comment:
这里为啥删了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
