Alanxtl commented on PR #3282: URL: https://github.com/apache/dubbo-go/pull/3282#issuecomment-4149428133
> here are some confusement about this issue > > 1. For P1–5, my understanding is that the original behavior may have been to append the new config and apply it together with the existing one. However, based on BaseConfigurationListener.Process, it seems the behavior there is to replace the existing config entirely. Which behavior is actually expected here? > 2. For P2-2, the original behavior in isMatched is to append. Replacing it with SetParam may change that behavior. Is that expected? > @Alanxtl @AlexStocks as for 2, do you mean P2-3? If the goal is only to avoid duplicate growth while preserving append semantics, another option would be to append only when configurators is not already present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
