xxs588 opened a new issue, #14: URL: https://github.com/apache/dubbo-go-extensions/issues/14
### ⚠️ Verification\n- [x] I have searched the existing issues in this repository and did not find a duplicate.\n- [x] I have checked previous migration discussion from dubbo-go main repo.\n\n### 🎯 Solution Description\nAfter hystrix filter was migrated from to (#3253 in dubbo-go), the implementation path changed to .\n\nTo reduce ambiguity for maintainers and users, I suggest clarifying the concurrency contract of the hystrix filter under parallel invocations:\n1. Document whether the filter is expected to be safe for concurrent calls by multiple goroutines.\n2. If there are constraints, explicitly state them in README / code comments.\n3. If needed, evaluate adding minimal serialization/guarding at the entry path (only if maintainers consider it necessary).\n\n### 📋 Use Cases\n- Users enabling / in high-concurrency scenarios need a clear thread-safety expectation.\n- Reviewers triaging race-condition issues need an explicit contract to decide whether a report is v alid bug or caller misuse.\n\n### ⚖️ Complexity & Risks\n- Documentation-only clarification is low risk and improves review consistency.\n- Adding runtime serialization guard may affect throughput, so it should be discussed before code changes.\n\n### 🔗 External Dependencies\n- behavior and guarantees.\n\n### 📘 Additional Context\n- Migration PR in main repo: https://github.com/apache/dubbo-go/pull/3253\n- Original review thread that requested follow-up after migration: https://github.com/apache/dubbo-go/pull/3269#discussion_r2985395111\n\nIf maintainers agree with this direction, I can follow up with a small PR in for docs/comments first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
