AlexStocks commented on code in PR #3252:
URL: https://github.com/apache/dubbo-go/pull/3252#discussion_r3004222187
##########
client/options.go:
##########
@@ -835,6 +857,20 @@ func WithClientParam(k, v string) ClientOption {
}
}
+// WithClientRouter appends router configurations to the client options.
+// This is a user-facing option for incrementally adding routers.
+// It appends to the current router slice instead of replacing it.
Review Comment:
[P1] nil 检查冗余。append 对 nil slice 安全，直接 opts.Routers = append(opts.Routers,
routers...) 即可。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
