AlexStocks commented on code in PR #3269:
URL: https://github.com/apache/dubbo-go/pull/3269#discussion_r2985395111
##########
filter/hystrix/filter.go:
##########
@@ -162,6 +162,7 @@ func (f *Filter) Invoke(ctx context.Context, invoker
base.Invoker, invocation ba
configLoadMutex.Unlock()
}
configLoadMutex.RLock()
+ methodRegexps := append([]*regexp.Regexp(nil),
f.res[invocation.MethodName()]...)
Review Comment:
这条问题目前还没处理。当前分支已经不再修改 `filter/hystrix/filter.go`，所以这次 race 修复没有覆盖到这里；如果这个 PR
不准备把 hystrix 一并收进来，建议至少后续单独补一个修复，把并发前提写清楚，或者在入口做串行化保护。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
