AlexStocks commented on code in PR #3235:
URL: https://github.com/apache/dubbo-go/pull/3235#discussion_r2969089068
##########
global/shutdown_config.go:
##########
@@ -41,6 +41,13 @@ type ShutdownConfig struct {
*/
StepTimeout string `default:"3s" yaml:"step-timeout"
json:"step.timeout,omitempty" property:"step.timeout"`
+ /*
+ * NotifyTimeout means the timeout budget for actively notifying
long-connection consumers
+ * during graceful shutdown. It only controls the notify step and
should not be coupled to
+ * request draining timeouts.
+ */
+ NotifyTimeout string `default:"5s" yaml:"notify-timeout"
json:"notify.timeout,omitempty" property:"notify.timeout"`
+
Review Comment:
## shutdown_config.go:174 - ClosingInvokerExpireTime 缺少文档注释
ClosingInvokerExpireTime 没有注释说明其用途，与同文件中其他字段的文档风格不一致。
**建议**: 添加类似其他字段的注释，说明这个配置的作用（如：consumer 端标记 invoker 为 closing 后的过期时间）。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
